perf: use requiresAttentionFromCurrentUser from a derived value #61586

TMisiukiewicz · 2025-05-07T13:43:01Z

Explanation of Change

requiresAttentionFromCurrentUser is already calculated in the reportAttributes so we can replace the function calls in the app with reading it straight from a derived value.

Function: requiresAttentionFromCurrentUser
Action: Create new chat
Before: 123ms
After: 11ms

Fixed Issues

$ #59350
$ #59825
PROPOSAL:

Tests

Open an app, ideally with no pinned/gbr/rbr reports and with at least two reports in the LHN
Pin one of the reports in the LHN
Create a task in another report and assign it to yourself
Verify the GBR is displayed next to the report
Verify the report with GBR goes above the pinned report

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…ntionFromCurrentUser-from-derived-value

TMisiukiewicz · 2025-05-08T11:24:10Z

There is still one requiresAttentionFromCurrentUser occurency in the codebase here. It's because in a derived value we pass parent report action to calculate it, and here it is not using it. Changing it to use a derived value makes tests fail, so I assume there might be a difference using between this and a derived value.

TMisiukiewicz · 2025-05-08T12:45:23Z

To avoid chaos, I'll undraft this one when we get #61376 merged, since they both share a bit of changes

…tentionFromCurrentUser-from-derived-value

TMisiukiewicz · 2025-05-12T07:14:32Z

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

@@ -73,13 +73,13 @@ export default createOnyxDerivedValueConfig({
                dataToIterate = prepareReportKeys(updates);
                recentlyUpdated = updates;
            } else if (!!transactionsUpdates || !!transactionViolationsUpdates) {
-                let transactionReportIds: string[] = [];
+                let transactionReportIDs: string[] = [];


Addressing this NAB comment from previous PR #61376 (comment) here cc @mountiny

melvin-bot · 2025-05-12T07:15:26Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-05-12T09:39:20Z

@allroundexperts can you please prioritize this one? thanks!

…tentionFromCurrentUser-from-derived-value

…om-derived-value

allroundexperts · 2025-05-14T22:53:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-05-15.at.4.16.02.AM.mov

iOS: HybridApp

Screen.Recording.2025-05-15.at.4.13.15.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-15.at.4.11.07.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-15.at.4.06.13.AM.mov

MacOS: Desktop

Screen.Recording.2025-05-15.at.4.19.02.AM.mov

allroundexperts · 2025-05-14T23:21:51Z

@TMisiukiewicz The report with task assigned doesn't always go up the pinned report.

Screen.Recording.2025-05-15.at.4.08.26.AM.mov

Screen.Recording.2025-05-15.at.4.15.02.AM.mov

gedu · 2025-05-15T08:08:16Z

@TMisiukiewicz is OOO, checking with the team if not I can take a look at this.

adhorodyski · 2025-05-15T08:08:21Z

@allroundexperts can you check if this is not the case in production? Spoke with Tomek and from his recent tests this was also reproducible there.

allroundexperts · 2025-05-16T22:17:33Z

@allroundexperts can you check if this is not the case in production? Spoke with Tomek and from his recent tests this was also reproducible there.

I can reproduce there, but the test steps state that "Verify the report with GBR goes above the pinned report". I guess those were not correct 😄

allroundexperts

Looks good!

mountiny

Don't want to block the improvement on this, but @TMisiukiewicz @kacper-mikolajczak @OlimpiaZurek could you take a look and make sure we do not use this getter pattern and always use the attributes from the onyx in component?

mountiny · 2025-05-20T17:46:31Z

src/libs/ReportUtils.ts

-let reportAttributes: ReportAttributesDerivedValue['reports'];
+let reportAttributesDerivedValue: ReportAttributesDerivedValue['reports'];
 Onyx.connect({
    key: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES,
    callback: (value) => {
        if (!value) {
            return;
        }
-        reportAttributes = value.reports;
+        reportAttributesDerivedValue = value.reports;
    },
 });


I believe this is an antipattern now and we should always subscribe to the attributes in the component using useOnyx and pass them to the utils method - this should ensure the component is always re-rendered when the attribute changes and that the utils method remains pure.

@TMisiukiewicz @kacper-mikolajczak what do you think? Could you look into this to refactor its usages?

I agree that it should be passed to the util methods from useOnyx. The only caveat is that in some cases, those values might be used deep within the function logic, not just as top-level arguments. Refactoring might result in passing them through multiple layers of intermediate calls.

I'll verify if it'll introduce the additional complexity

mountiny · 2025-05-20T17:47:24Z

src/libs/ReportUtils.ts

+function getReportAttributes(reportID: string | undefined, reportAttributes?: ReportAttributesDerivedValue['reports']) {
+    const attributes = reportAttributes ?? reportAttributesDerivedValue;
+
+    if (!reportID || !attributes?.[reportID]) {
+        return;
+    }
+    return attributes[reportID];
+}
+


I think we dont want to create these getters in general and always use the attributes fetched from onyx in the component

Addressed this comment here: #62464

daledah · 2025-05-20T18:01:13Z

@mountiny This PR forgot to update variable name from reportAttributes to reportAttributesDerivedValue here:

App/src/libs/ReportUtils.ts

Line 7454 in 6c81877

const attributes = reportAttributes?.[report.reportID];

So app crashes.

mountiny · 2025-05-20T18:14:25Z

https://github.com/Expensify/App/pull/62416/files

kacper-mikolajczak · 2025-05-20T20:23:07Z

Hi @mountiny 👋 @TMisiukiewicz is currently OOO - quickly looking at it now and it is a nice structural improvement, I am going to look into it more carefully tomorrow 👍 🔜

TMisiukiewicz · 2025-05-21T06:44:04Z

Hey I'm back 👋 I'll create a follow up PR today

github-actions · 2025-05-21T18:29:46Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-21T21:00:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-22T10:52:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.49-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2025-05-23T01:15:54Z

We've got an intermittent issue. Team was not able to consistently repro.

Report with GBR goes under the pinned report for expense reports. However issue is not repro for direct message reports

video_63.mp4

mountiny · 2025-05-23T11:57:45Z

@kacper-mikolajczak @TMisiukiewicz can you take a look please?

TMisiukiewicz · 2025-05-23T12:07:34Z

@mountiny in getOrderedReportIDs we sort pinned items and GBRs by display name:

App/src/libs/SidebarUtils.ts

Line 311 in 37b4ab8

    
           pinnedAndGBRReports.sort((a, b) => (a?.displayName && b?.displayName ? localeCompare(a.displayName, b.displayName) : 0));

I assume it's an expected behavior:

github-actions · 2025-05-23T19:04:37Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

TMisiukiewicz added 2 commits May 7, 2025 10:26

migrate requiresAttentionFromCurrentUser to a derived value

b69416d

Merge remote-tracking branch 'origin/main' into perf/use-requiresAtte…

db637f9

…ntionFromCurrentUser-from-derived-value

TMisiukiewicz mentioned this pull request May 7, 2025

perf: move report brick road statuses to a derived value #60827

Merged

51 tasks

TMisiukiewicz added 5 commits May 7, 2025 15:55

fix typecheck

49526e3

fix lint changed

81d1056

fix SidebarOrderTest

38e9a46

fix tests

29b960e

fix lint changed

21cef0a

remove unnecessary param

407bd0e

TMisiukiewicz added 2 commits May 12, 2025 09:00

Merge remote-tracking branch 'upstream/main' into perf/use-requiresAt…

e4a18b1

…tentionFromCurrentUser-from-derived-value

update variable name

68688b3

TMisiukiewicz commented May 12, 2025

View reviewed changes

TMisiukiewicz marked this pull request as ready for review May 12, 2025 07:15

TMisiukiewicz requested a review from a team as a code owner May 12, 2025 07:15

melvin-bot bot requested a review from allroundexperts May 12, 2025 07:15

melvin-bot bot removed the request for review from a team May 12, 2025 07:15

TMisiukiewicz added 2 commits May 12, 2025 11:21

use getReportAttributes function

96eb9fd

update submodule

e201d75

mountiny assigned TMisiukiewicz May 12, 2025

TMisiukiewicz mentioned this pull request May 13, 2025

[Due for payment 2025-05-30] [Due for payment 2025-05-22] [Due for payment 2025-05-20] [Due for payment 2025-04-25] [$250] Use onyx derivedValue for more computation heavy report properties #59350

Open

TMisiukiewicz added 3 commits May 13, 2025 10:34

update getReportAttributes function

bf3e2b7

Merge remote-tracking branch 'upstream/main' into perf/use-requiresAt…

7a0fc0e

…tentionFromCurrentUser-from-derived-value

Merge branch 'main' into perf/use-requiresAttentionFromCurrentUser-fr…

e3cd75b

…om-derived-value

allroundexperts approved these changes May 16, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny May 16, 2025 22:29

mountiny approved these changes May 20, 2025

View reviewed changes

mountiny merged commit 6c81877 into Expensify:main May 20, 2025
18 checks passed

mountiny mentioned this pull request May 20, 2025

[NoQA] Use correct variable name after renaming #62416

Merged

51 tasks

github-actions bot mentioned this pull request May 21, 2025

Deploy Checklist: New Expensify 2025-05-21 #62497

Closed

melvin-bot bot mentioned this pull request May 23, 2025

[Due for payment 2025-05-30] [CRITICAL] Investigate performance issues when deleting expenses from Reports page #59825

Open

18 tasks

perf: use requiresAttentionFromCurrentUser from a derived value #61586

perf: use requiresAttentionFromCurrentUser from a derived value #61586

Uh oh!

Conversation

TMisiukiewicz commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

TMisiukiewicz commented May 8, 2025

Uh oh!

TMisiukiewicz commented May 8, 2025

Uh oh!

TMisiukiewicz May 12, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 12, 2025

Uh oh!

mountiny commented May 12, 2025

Uh oh!

allroundexperts commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented May 14, 2025

Uh oh!

gedu commented May 15, 2025

Uh oh!

adhorodyski commented May 15, 2025

Uh oh!

allroundexperts commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny May 20, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz May 21, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny May 20, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daledah commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented May 20, 2025

Uh oh!

kacper-mikolajczak commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TMisiukiewicz commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 22, 2025

Uh oh!

mvtglobally commented May 23, 2025

Uh oh!

mountiny commented May 23, 2025

Uh oh!

TMisiukiewicz commented May 23, 2025

Uh oh!

TMisiukiewicz commented May 7, 2025 •

edited

Loading

allroundexperts commented May 14, 2025 •

edited

Loading

allroundexperts commented May 16, 2025 •

edited

Loading

daledah commented May 20, 2025 •

edited

Loading

kacper-mikolajczak commented May 20, 2025 •

edited

Loading